Fix pom involving maven-archetype and opentelemetry by Abacn · Pull Request #38518 · apache/beam

Abacn · 2026-05-15T18:24:57Z

Please add a meaningful description for your change here

Tested: ./gradlew :runners:google-cloud-dataflow-java:publishToMavenLocal -Ppublishing then mvn dependency:tree -Pdataflow-runner from maven archetype project can show transitive dependencies of this module

[INFO] org.example:word-count-beam:jar:0.1
[INFO] \- org.apache.beam:beam-runners-google-cloud-dataflow-java:jar:2.75.0-SNAPSHOT:compile
[INFO]    +- org.checkerframework:checker-qual:jar:3.42.0:compile
[INFO]    +- org.apache.beam:beam-vendor-guava-32_1_2-jre:jar:0.1:compile
[INFO]    +- org.apache.beam:beam-model-pipeline:jar:2.75.0-SNAPSHOT:compile
[INFO]    |  +- com.google.auto.value:auto-value-annotations:jar:1.8.2:compile
...

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
Update CHANGES.md with noteworthy changes.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

* Fix opentelemetry version * Fix target platform version to be 11

gemini-code-assist · 2026-05-15T18:38:49Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses dependency resolution issues involving OpenTelemetry and Maven archetypes. By aligning OpenTelemetry dependencies with the project's BOM and upgrading the default Java target platform, the changes ensure better compatibility and correct transitive dependency resolution for users of the Beam Maven archetypes.

Highlights

Dependency Management: Updated OpenTelemetry dependency definitions in the Gradle plugin to rely on the OpenTelemetry BOM and explicitly set the version for the context module.
Java Version Update: Increased the default target platform version from 1.8 to 11 in Maven archetype configurations and test resources.

New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request updates OpenTelemetry dependency management by switching BOM references and adding an explicit version for the context module. It also upgrades the default Java target platform from 1.8 to 11 in Maven archetypes. Feedback indicates that explicit versions should also be added to other OpenTelemetry artifacts (api, sdk, exporter-otlp, and autoconfigure) to ensure correct propagation to generated POMs. Furthermore, the Java version upgrade is a breaking change that needs to be documented.

gemini-code-assist · 2026-05-15T18:40:08Z

        netty_transport                             : "io.netty:netty-transport:$netty_version",
        netty_transport_native_epoll                : "io.netty:netty-transport-native-epoll:$netty_version",
-        opentelemetry_api                           : "io.opentelemetry:opentelemetry-api", // google_cloud_platform_libraries_bom sets version
+        opentelemetry_api                           : "io.opentelemetry:opentelemetry-api", // opentelemetry-bom sets version


The issue #30505 specifically mentions that opentelemetry-api and opentelemetry-sdk are missing versions in the generated POMs. While you've added an explicit version for opentelemetry_context at line 864, opentelemetry_api still lacks one. It should likely be updated to include $opentelemetry_version to ensure it is correctly propagated to the archetype POMs.

opentelemetry_api : "io.opentelemetry:opentelemetry-api:$opentelemetry_version", // opentelemetry-bom sets version

gemini-code-assist · 2026-05-15T18:40:08Z

+        opentelemetry_sdk                           : "io.opentelemetry:opentelemetry-sdk", // opentelemetry-bom sets version
+        opentelemetry_exporter_otlp                 : "io.opentelemetry:opentelemetry-exporter-otlp", // opentelemetry-bom sets version
+        opentelemetry_extension_autoconfigure       : "io.opentelemetry:opentelemetry-sdk-extension-autoconfigure", // opentelemetry-bom sets version


Similar to opentelemetry_api, these artifacts (sdk, exporter-otlp, and autoconfigure) should also have explicit versions to resolve the issues reported in #30505 regarding missing versions in published POMs used by archetypes.

opentelemetry_sdk : "io.opentelemetry:opentelemetry-sdk:$opentelemetry_version", // opentelemetry-bom sets version opentelemetry_exporter_otlp : "io.opentelemetry:opentelemetry-exporter-otlp:$opentelemetry_version", // opentelemetry-bom sets version opentelemetry_extension_autoconfigure : "io.opentelemetry:opentelemetry-sdk-extension-autoconfigure:$opentelemetry_version", // opentelemetry-bom sets version

These modules are currently only used in java-core, where enforcePlatform(opentelemetry-bom) is correctly configured. For other places, only opentelemetry_context is used. Adding a version in beampluginmodule will force the Beam modules pin on this version.

gemini-code-assist · 2026-05-15T18:40:08Z

  <requiredProperties>
    <requiredProperty key="targetPlatform">
-      <defaultValue>1.8</defaultValue>
+      <defaultValue>11</defaultValue>


Upgrading the default targetPlatform from 1.8 to 11 is a breaking change for users of these archetypes who are still on Java 8. This change should be explicitly documented in the PR description and CHANGES.md.

Abacn · 2026-05-15T19:17:46Z

R: @aIbrahiim

github-actions · 2026-05-15T19:19:00Z

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

aIbrahiim · 2026-05-15T19:29:01Z

LGTM from my side

* Fix opentelemetry version * Fix target platform version to be 11

[Release-2.74] Cherry-pick #38518 into release branch

* Fix opentelemetry version * Fix target platform version to be 11

github-actions Bot added java build labels May 15, 2026

Abacn mentioned this pull request May 15, 2026

Fix Dataflow archetype missing API client dependency #38509

Merged

3 tasks

Fix pom involving maven-archetype and opentelemetry

9093f36

* Fix opentelemetry version * Fix target platform version to be 11

Abacn force-pushed the fix-maven branch from e83f2f7 to 9093f36 Compare May 15, 2026 18:30

gemini-code-assist Bot reviewed May 15, 2026

View reviewed changes

Amar3tto approved these changes May 15, 2026

View reviewed changes

Abacn merged commit b2d0ef6 into apache:master May 15, 2026
20 of 22 checks passed

Abacn mentioned this pull request May 15, 2026

Revert "Fix Dataflow archetype missing API client dependency" #38519

Merged

Amar3tto pushed a commit that referenced this pull request May 16, 2026

Fix pom involving maven-archetype and opentelemetry (#38518)

4cbe64c

* Fix opentelemetry version * Fix target platform version to be 11

Amar3tto added a commit that referenced this pull request May 16, 2026

Merge pull request #38520 from Abacn/cp-38518

61efb9f

[Release-2.74] Cherry-pick #38518 into release branch

ash6898 pushed a commit to ash6898/beam that referenced this pull request Jun 29, 2026

Fix pom involving maven-archetype and opentelemetry (apache#38518)

31453b8

* Fix opentelemetry version * Fix target platform version to be 11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix pom involving maven-archetype and opentelemetry - #38518

Fix pom involving maven-archetype and opentelemetry#38518
Abacn merged 1 commit into
apache:masterfrom
Abacn:fix-maven

Abacn commented May 15, 2026

Uh oh!

gemini-code-assist Bot commented May 15, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot May 15, 2026

Uh oh!

gemini-code-assist Bot May 15, 2026

Uh oh!

Abacn May 15, 2026

Uh oh!

gemini-code-assist Bot May 15, 2026

Uh oh!

Abacn May 15, 2026

Uh oh!

Abacn commented May 15, 2026

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

aIbrahiim commented May 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Abacn commented May 15, 2026

GitHub Actions Tests Status (on master branch)

Uh oh!

gemini-code-assist Bot commented May 15, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot May 15, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 15, 2026

Choose a reason for hiding this comment

Uh oh!

Abacn May 15, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 15, 2026

Choose a reason for hiding this comment

Uh oh!

Abacn May 15, 2026

Choose a reason for hiding this comment

Uh oh!

Abacn commented May 15, 2026

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

aIbrahiim commented May 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants